add markdown-specific styles for Atom #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
adds styling for markdown in Atom
how
Atom already adds classes to markdown dynamically, so adding some .css for those classes is all that's necessary to add colors to .md documents
concerns
All headings have the same level and font-weight differentiates the first three levels. There's no great way (that I could think of) to continue this sequence down to h7, so h4 and lower all just a normal font weight. Also at least operator mono the bold weight is kind of ugly ¯_(ツ)_/¯
a new background-color is added for code snippets, which hopefully will allow for syntax highlighting when Atom improves markdown support. I checked this new background with our existing font colors and it still passes the accessible colors test
acknowledgements
Ariel helped me figure this out