Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with new twitter logo #1287

Merged
merged 5 commits into from
Oct 29, 2023
Merged

Conversation

aslezar
Copy link
Contributor

@aslezar aslezar commented Oct 26, 2023

Updated Read Me with the new updated logo of twitter.

@YasharF
Copy link
Collaborator

YasharF commented Oct 27, 2023

Also, while you are at it, can you also go thru the readme.md and replace the word "Twitter" with "X (Twitter)" everywhere in that file?

@aslezar aslezar closed this Oct 27, 2023
@aslezar aslezar reopened this Oct 27, 2023
@aslezar
Copy link
Contributor Author

aslezar commented Oct 27, 2023

Also, while you are at it, can you also go thru the readme.md and replace the word "Twitter" with "X (Twitter)" everywhere in that file?

Yeah, sure!
I have made the required changes.

@YasharF
Copy link
Collaborator

YasharF commented Oct 27, 2023

Let's set it as upper case (Twitter) instead of (twitter). I made a couple of comments in-line as well.

Changed twitter to Twitter
@aslezar
Copy link
Contributor Author

aslezar commented Oct 27, 2023

Let's set it as upper case (Twitter) instead of (twitter). I made a couple of comments in-line as well.

Replaced twitter with Twitter.

I couldn't find any in-line comments that mention the word 'twitter'. If you're referring to the API routes or links like this one https://apps.twitter.com, I haven't changed them as it would affect functionality."

@YasharF
Copy link
Collaborator

YasharF commented Oct 27, 2023

Look at the PR in github, I commented the PR

@aslezar
Copy link
Contributor Author

aslezar commented Oct 27, 2023

Hey, thanks for your time, but I didn't quite understand what you're talking about. It would be great if you could elaborate a bit, if possible. 😅

@YasharF
Copy link
Collaborator

YasharF commented Oct 27, 2023

@aslezar
image

Changed twitter logo url with imgur one and corrected language.
@aslezar
Copy link
Contributor Author

aslezar commented Oct 28, 2023

@aslezar image

Thanks for the help!
I have made the requested changes.

@YasharF
Copy link
Collaborator

YasharF commented Oct 29, 2023

The logo completely disappears in dark mode
image

@aslezar
Copy link
Contributor Author

aslezar commented Oct 29, 2023

I have updated it with the jpg image, it will render now correctly in dark mode.

@YasharF
Copy link
Collaborator

YasharF commented Oct 29, 2023

Thank you!

@YasharF YasharF merged commit ed7f82d into sahat:master Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants