Fix(1030): adds a customizable property for aria-label #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this implemented! Running into a related issue trying to get a site that uses vue-select with ADA compliance. |
|
@ma31cm @merziy Hello, if you are using Vue 3, welcome to submit a pull request to the following forked repository. https://github.com/howard-tzw/vue3-select I have available time to maintain this project, but it may be limited to the Vue 3 version. |
|
@howard-tzw Thank you. @ma31cm Is this something you have time to do? |
|
@merziy You can now use the property of this PR in vue3-select@0.0.8, thanks to @ma31cm |
|
@howard-tzw Sorry for the slow reply - somehow your comment completely passed me by! But thank you, that's great 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aria-label for the search input is currently hard-coded to "Search for option". This causes problems for screen reader users and fails WCAG 2.1 criteria 2.5.3 and 3.3.1.
This PR adds a new property 'ariaLabel' that can be used to change the value of aria-label for the search input. This fixes (or at least partially fixes) the following issues: