Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 libs.0 zksync #588

Open
wants to merge 77 commits into
base: v1_3_0_zksync
Choose a base branch
from

Conversation

nick8319
Copy link

This PR adds support to test and deploy safe-contracts 1.3.0 to zkSync network.
The process is described in zkSync Network section in Readme.md

@nick8319 nick8319 marked this pull request as draft June 13, 2023 14:04
package.json Outdated
@@ -44,31 +47,36 @@
"url": "https://github.com/gnosis/gnosis-safe/issues"
},
"devDependencies": {
"@elvis-krop/hardhat-deploy": "0.11.29-ethers5.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference of this to the normal hardhat-deploy?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rmeissner 👋
We are waiting for an action under this PR in hardhat-deploy. You can read more details in the description.

During the development, we realised that v0.11.25 and previous versions doesn't work properly for zkEVM deployments and testing. Moreover, v0.11.26 and further releases include incompatible versions of @ethersproject/* with safe-contracts repo ethers.js and some tools for testing.

We expected to have an intermediate release of hardhat-deploy for this, however owner doesn't reply us

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that they will be downgrading their ethers dependency. You can force a specific resolution of a dependency with yarn afaik (see https://classic.yarnpkg.com/en/docs/selective-version-resolutions/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rmeissner!
✔️ done at b492bce

@nick8319 nick8319 marked this pull request as ready for review June 28, 2023 18:21
@rmeissner
Copy link
Member

Just to note: we will not merge this PR as this is just a temporary solution to deploy 1.3.0.
The final goal is to enable this for 1.4.1 and make this a default for all zkSync chains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants