Allow query params to get_transactions api method #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
approved these changes
May 13, 2024
|
|
||
| if kwargs: | ||
| query_string = urlencode( | ||
| {key: f"{value}" for key, value in kwargs.items() if value is not None} |
There was a problem hiding this comment.
No strong preference but str(value) might look more clear? I don't know
gnosis/safe/api/transaction_service_api/transaction_service_api.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Uxío <Uxio0@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #890