Better version :) #114
Open
Better version :) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CommandType enum was removed because it wasn't being used. The SlashCommandBuilder was replaced with an object literal to define the command's data. This is simpler and more concise. The getMemberAndUser method was removed because it wasn't being used. Instead, the target user is retrieved from the interaction's options or default to the invoking user. The EmbedBuilder was replaced with a plain object to define the embed's options. This is simpler and more concise. The code that sets the embed's color was moved to a separate getColor function, which is more modular and easier to test. This function tries to get the user's display color from each guild they're in, returning the first non-black color it finds. If it fails, it logs an error and returns undefined. The client.reply method was replaced with interaction.reply, which is more concise and clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CommandType enum was removed because it wasn't being used. The SlashCommandBuilder was replaced with an object literal to define the command's data. This is simpler and more concise. The getMemberAndUser method was removed because it wasn't being used. Instead, the target user is retrieved from the interaction's options or default to the invoking user. The EmbedBuilder was replaced with a plain object to define the embed's options. This is simpler and more concise. The code that sets the embed's color was moved to a separate getColor function, which is more modular and easier to test. This function tries to get the user's display color from each guild they're in, returning the first non-black color it finds. If it fails, it logs an error and returns undefined. The client.reply method was replaced with interaction.reply, which is more concise and clearer.