Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker and Dockerfile Added #267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Docker and Dockerfile Added #267

wants to merge 2 commits into from

Conversation

xShuden
Copy link

@xShuden xShuden commented Oct 18, 2019

What does it implement/fix? Explain your changes.

Where has this been tested?

Python Version:
Operating System:

Does this close any currently open issues?

Does this add any new dependency?

Does this add any new command line switch/option?

Any other comments you would like to make?

Some Questions

  • I have documented my code.
  • I have tested my build before submitting the pull request.

@PhilParisot
Copy link

Why has this not been merged yet?

Dockerfile Outdated Show resolved Hide resolved
@@ -0,0 +1,9 @@
FROM xshuden/alppython3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM xshuden/alppython3
FROM python:3

need to check whether git is installed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In alppython3 you can check it on the git loaded hub.

@xShuden xShuden closed this Apr 20, 2020
@xShuden xShuden reopened this Apr 20, 2020
Copy link
Author

@xShuden xShuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change

Co-Authored-By: Fabian Foerg <fabian.foerg@addepar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants