Adding VNC Info #83
Adding VNC Info #83
Conversation
| TimedOut bool `json:"timedOut"` | ||
| } | ||
|
|
||
| type ProtocolInfo struct { |
There was a problem hiding this comment.
Looks like a good approach to me. Maybe adding a port number in here would make sense to prepare for protocols and ports to be decoupled more (#46)
| } | ||
|
|
||
| func (osr *OnionScanReport) AddProtocolInfo(protocolType string, protocolPort uint, protocolInfo interface{}) { | ||
| osr.ProtocolInfoList = append(osr.ProtocolInfoList, ProtocolInfo{protocolType, protocolPort, protocolInfo}) |
There was a problem hiding this comment.
I'm having a try at porting over some other scans to this system and just noticed that osr.ProtocolInfoList is not initialized to an empty list, so it will be null instead of [] if nothing is found. Dunno if that's a problem.
There was a problem hiding this comment.
Thanks. We should probably initialize this for consistency.
I'm still trying to work out the best approach here....given a proper database structure. I should have more of an idea soon - I would hold off on porting any of the other scans until then.
There was a problem hiding this comment.
It's just the the BitcoinService was already so similar, and it seems like an elegant approach. But I'll hold it off for now.
|
|
||
| type ProtocolInfo struct { | ||
| Type string `json:"type"` | ||
| Port uint `json:"port:` |
There was a problem hiding this comment.
should json:"port: be json:"port"?
Playing with a new way of adding derived protocol info. Leaving as a PR for now.