Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation.go #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lovegreen1321
Copy link

Changed

@Weldeasy
Copy link

Merge this bad boy!

@mikelolasagasti
Copy link

This breaks a test, as the new regexp accepts anything between 16 and 56:

https://github.com/s-rah/onionscan/blob/master/utils/validation_test.go#L29=

I think (^|\.)[a-z2-7]{16}\.onion$|(^|\.)[a-z2-7]{56}\.onion$ would be more correct, as matches either 16 or 56 length domain names.

@VityaSchel
Copy link

@s-rah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants