Add Makefile and document how to build/install #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
rylev
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks! I'm not ready to commit to having a Makefile which I generally am not a fan of (for the fact that Makefiles get complicated very quickly). I'd prefer we document the plain Cargo instructions in the readme and get rid of the Makefile for now. Would you be able to update this PR to do that?
|
Thanks for coming back so quickly @rylev |
Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
rylev
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple
Makefilewhich allows users tobuildandinstalltheweplCLI locally. Additionally, building from source and installing locally has been documented inREADME.md