Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0.docker #656

Open
wants to merge 27 commits into
base: 4.0.0
Choose a base branch
from
Open

4.0.0.docker #656

wants to merge 27 commits into from

Conversation

leolivier
Copy link

Please cancel previous PR on Docker and use this one. This is exactly the same but on a clean branch on my side, not merged with french stuff.

@leolivier
Copy link
Author

Hello, the checks above (codacy) does not check the commit at all, it checks some core files I didn't change at all...
@ryanhowdy dy I did that PR 2 months ago, do you intend to review it?

@ryanhowdy
Copy link
Owner

Yea you can ignore the codacy checks, that hasn't been configured correctly yet anyway.

And sorry for the delay on reviewing this, my plan was to review it after I was done with all the other 4.0.0 code i've been working on (which is quite a lot). Currently I have 2 problems, 1) I'm busy with other code, and 2) I'm not that familiar with docker configurations right now to even decide how this should all work.

I do however appreciate the work you've done and thank you for your time. Again, sorry that I'm so slow to respond. Lots of work and little time.

@leolivier
Copy link
Author

Hi, I updated the PR to remove apache and use directly php artisan serve.
This results in a much lighter image (~400MB instead of ~700MB) and being based on simpler images, it does not contain any CVE (checked with Docker scout review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants