-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0.0.docker #656
base: 4.0.0
Are you sure you want to change the base?
4.0.0.docker #656
Conversation
… setup at build or runtime
Hello, the checks above (codacy) does not check the commit at all, it checks some core files I didn't change at all... |
merge ryanhoddy 4.0.0 new commits
Yea you can ignore the codacy checks, that hasn't been configured correctly yet anyway. And sorry for the delay on reviewing this, my plan was to review it after I was done with all the other 4.0.0 code i've been working on (which is quite a lot). Currently I have 2 problems, 1) I'm busy with other code, and 2) I'm not that familiar with docker configurations right now to even decide how this should all work. I do however appreciate the work you've done and thank you for your time. Again, sorry that I'm so slow to respond. Lots of work and little time. |
Hi, I updated the PR to remove apache and use directly php artisan serve. |
Please cancel previous PR on Docker and use this one. This is exactly the same but on a clean branch on my side, not merged with french stuff.