Update binscripts/rvm-installer #5148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -q option to curl flags to avoid user custom definitions in .curlrc file. In some cases, user-defined configuration such as: -w "\n" will cause the asc signature file to be changed and cannot be verified.
mpapis
requested changes
Nov 15, 2021
| @@ -205,7 +205,7 @@ __rvm_curl() | |||
| } | |||
|
|
|||
| typeset -a __flags | |||
| __flags=( --fail --location --max-redirs 10 ) | |||
| __flags=( -q --fail --location --max-redirs 10 ) | |||
There was a problem hiding this comment.
I would rather go with:
Suggested change
| __flags=( -q --fail --location --max-redirs 10 ) | |
| __flags=( $RVM_CURL_FLAGS --fail --location --max-redirs 10 ) |
this way you can overwrite any setting you like, but in most cases the .curlrc will be what users need like proxies, in case users have some nonstandard settings they can overwrite it.
alivx
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -q option to curl flags to avoid user custom definitions in .curlrc
file.
In some cases, user-defined configuration such as: -w "\n" will cause
the asc signature file to be changed and cannot be verified.