Add CODEOWNERS and fix+extend mergeable config #4963
Conversation
pkuczynski
commented
Jul 10, 2020
pkuczynski
commented
- add CODEOWNERS
- fix meargeble config issues
- add automatic assigning
- add validating aprovals
- add handling stale PR
|
This PR does not contain all required information and changes. Please review the |
|
This PR does not contain all required information and changes. Please review the If you are member of the RVM team, ensure that you have applied all necessary labels, milestones, etc. |
|
This PR does not contain all required information and changes. Please review the If you are member of the RVM team, ensure that you have applied all necessary labels, milestones, etc. |
|
This PR does not contain all required information and changes. Please review the If you are member of the RVM team, ensure that you have applied all necessary labels, milestones, etc. |
| @@ -0,0 +1 @@ | |||
| * @rvm/maintainers @rvm/contributors | |||
There was a problem hiding this comment.
i'll double check if mergeable has implemented team member functionality for CODEOWNERS. I suspect that this will not work as expected with mergeable currently.
There was a problem hiding this comment.
Should work https://github.com/mergeability/mergeable#approvals :)
There was a problem hiding this comment.
At least that's what the documentation says...
There was a problem hiding this comment.
Actually seems it does not work: https://github.com/rvm/rvm/pull/4963/checks?check_run_id=858856086
✔️ approvals: all required reviewers have approved
Input :
Settings : {"required":{"owners":true,"assignees":true}}
No owner approved yet! However maybe its reading CODEOWNERS from master and not from PR?
There was a problem hiding this comment.
hmm.. it's as i expected, passing in a team name instead of individual name requires extra code which is not implemented in mergeable yet.
There was a problem hiding this comment.
At least that's what the documentation says...
yeah, CODEOWNERS should work for individuals for sure. we didn't account for teams.
There was a problem hiding this comment.
@shine2lay have this been fixed on your side maybe?
There was a problem hiding this comment.
yes, this feature has been implemented
.github/mergeable.yml
Outdated
| pass: | ||
| - do: comment | ||
| payload: | ||
| body: There was no activity for 20 dats. Is this still relevant? |
|
@shine2lay I didn't realized it would create separate checks when I add "names" |
|
@pkuczynski each recipe ( |
# Conflicts: # .github/mergeable.yml
