Fix install when user home directory contains @ symbol #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…separator' rvm_gemset_separator defines the string used to separate the the ruby and the gemset. Traditionally, '@' is used to separate the two. Throughout the code 'rvm_gemset_separator' is used, however in parts of the code '@' is used instead of the variable. Testing Notes rvm-test/fast/* These tests are currently failing on travisci as well as my local machine. ##### Processed commands 622 of 622, success tests 432 of 434, failure tests 2 of 434. $ rvm 2.3.4@global,2.3.4 do rvm gemdir # failed: match = /2.3.4@global$/ $ bundle config # failed: status = 127 # was 0 rvm-test/long/named_ruby_and_gemsets_comment_test.sh ##### Processed commands 21 of 21, success tests 27 of 27. rvm-test/long/truffleruby_comment_test.sh ##### Processed commands 13 of 13, success tests 21 of 21. rvm-test-rvm1/* ##### Processed commands 378 of 378, success tests 206 of 207, failure tests 1 of 207. $ PATH="$( echo $PATH | sed 's/^.*rvm[^:]*://' )" The rvm-test-rvm1/load_ruby-version_comment_test.sh failed on my local master branch as well.
* Fixes a few more instances of rvm_gemset_separator not being used where '@' is used. * one simple unit test was added * the fast/* suite was copied then modified to execute all the fast tests with a custom gemset separator * The only separator tested is '@@'
pkuczynski
reviewed
Dec 19, 2019
* Unintentional deletion.
|
Your PR seems to break |
pkuczynski
changed the title
|
It will be a while. I am in a city that is locked down and my main computer
is in another city. I'll see what I can do with the resources I have here.
…On Wed, Mar 25, 2020 at 4:06 PM Piotr Kuczynski ***@***.***> wrote:
Your PR seems to break rvm-test included as a separate repository. Can
you fix it please?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4832 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJH7NZ56YXOEQ5NSBTAFLRJJW5JANCNFSM4J427Y2Q>
.
--
Love, Luck and Lollipops
Felix
|
|
@dacat any update? |
|
@pkuczynski The rvm-test directory is a git subtree for rvm/rvm-test. The test's i added need to be pushed to rvm/rvm-test. Is that correct? Also, the failing tests in rvm-test are the same that are failing in the master branch. |
|
Yes, that's correct. You need to add your tests to rvm-test repo. I can add you to our slack. Just don't see your email? |
|
@pkuczynski See rvm/rvm-test#29 (comment) and https://github.com/rvm/rvm/commits/master/rvm-test |
|
@dacat how its going with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3790 .
This provides for a workaround with users who have @ in their username.
It does this by:
A simple unit test is provided in rvm-test/fast and a more robust set of tests provided in rvm-test/gemset_separator_tests. The test runner,rvm-test/fast/rvm_gemset_separator_comment_test.sh, allows you test different gemset separators. Right now it tests only '@@' and all the tests pass.
Note: The build for this branch fails with the same failures that are in master.