[WIP] Ruby 2.3.8 should be able to use openssl 1.0 #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whs-dot-hk
changed the title
pkuczynski
reviewed
Dec 3, 2019
| @@ -307,7 +307,7 @@ requirements_osx_brew_define_openssl() | |||
|
|
|||
| case "$1" in | |||
| (ruby-2.3*|ruby-2.2*|ruby-2.1*|ruby-2.0*|ruby-1.9*|ruby-1.8*) | |||
| brew_openssl_package="openssl" | |||
| brew_openssl_package="https://raw.githubusercontent.com/Homebrew/homebrew-core/8c9b113bc6812dc74c598c8f860017e42fba8d78/Formula/openssl.rb" | |||
There was a problem hiding this comment.
This could maybe work but should be rather done behind some IF, as someone might have older macOS where this openssl version is simply available.
There was a problem hiding this comment.
Hi, I should add a openssl version check
but more problem came alone as other homebrew package e.g. mariadb use openssl 1.1
/usr/local/opt/openssl will then be link to 1.1
so again ruby 2.3 won't work
There was a problem hiding this comment.
yes, I tried this and it can not be linked correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4781.
Changes proposed in this pull request:
rvm reinstall ruby-2.3.8 --with-openssl-dir='/usr/local/Cellar/openssl/1.0.2t' --debugwould workMake sure that your pull request includes entry in the CHANGELOG.