Use doas for OpenBSD #4733
Open
Use doas for OpenBSD #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oridb
force-pushed
the
master
branch
2 times, most recently
from
d5587e4
to
36635ff
Compare
pkuczynski
requested changes
Jul 23, 2019
It's the new hotness, we no longer have sudo.
|
ping? (The test failures look odd to me, and I'm not sure how this change could have broken them.) |
|
@oridb sorry for delay. I made one more comment, as I don't think you solved the previous one the way I suggested? Do you need help with this? |
|
@oridb Any update on changing the implementation as @pkuczynski suggested in his initial code comment? I'd love to test rvm on OpenBSD. |
|
I'm hitting this issue but with doas on FreeBSD. Can you include FreeBSD + doas support too, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the new hotness, we no longer have sudo shipped by default on openbsd. The doas command first appeared in openbsd 5.8.
Fixes #4732 .
Changes proposed in this pull request:
doas, use it as a fallback to sudo. Default to sudo in rvm.sh on OpenBSD.