-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output correct environment path. #3483
base: master
Are you sure you want to change the base?
Conversation
The build is failing here:
i noticed that the way the command is being tested is not as the one explained in the documentation of rvm. https://rvm.io/deployment/cron#loading-rvm-environment-files-in-shell-script to fix this i need to know what is the correct way to execute the command, thanks. |
scripts/functions/env
Outdated
@@ -272,7 +272,26 @@ __rvm_env_print() | |||
if | |||
[[ "$rvm_path_flag" == "1" || "$*" == *"--path"* ]] | |||
then | |||
echo "$environment_file_path" | |||
if | |||
[[ ! -z "$@" ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-n
is a tad more concise than ! -z
for the string-isn't-null test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right @havenwood thanks, i will update it.
@@ -656,6 +656,7 @@ __rvm_parse_args() | |||
rvm_token=${rvm_token#--} | |||
rvm_token=${rvm_token//-/_} | |||
export "rvm_${rvm_token}_flag"=1 | |||
rvm_ruby_args+=($next_token); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not look good, the options here do not take arguments and next_token
is what's listed after them, could be anything
Pull requets to fix the "'env' command doesn't operate as expected #3465" issue