Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 6 compatibility #125

Open
wants to merge 14 commits into
base: 3.x
Choose a base branch
from
Open

Symfony 6 compatibility #125

wants to merge 14 commits into from

Conversation

studio-m2v
Copy link

Some changes to be compatible with Symfony 6 and PHP 8.x

@brzuchal
Copy link

brzuchal commented Jan 3, 2023

@dmishh can we have this?

@rvanlaak
Copy link
Owner

rvanlaak commented Jan 3, 2023

What I am curious about is why tests do not get executed. Can you rebase on master?

@dmishh
Copy link
Collaborator

dmishh commented Jan 11, 2023

@brzuchal hey, I no longer maintain this repo. Richard is the one :)
btw, @rvanlaak do you want to take over this repo? I'd like to transfer it to your account since you're maintaining it like you're the owner. Maybe some listings on the packagist will need to be updated, etc

@rvanlaak
Copy link
Owner

@dmishh yes please do!

But, maybe @FriendsOfSymfony or another group is even a better and more sustainable place?

@dmishh
Copy link
Collaborator

dmishh commented Jan 17, 2023

@rvanlaak I'd rather transfer to your account since you were the main contributor all the time after I stopped supporting the project. How about the packagist name or anything else required to make the transfer smooth for the users?

@rvanlaak
Copy link
Owner

Yes, please feel free to do so.

@dmishh
Copy link
Collaborator

dmishh commented Jan 24, 2023

@rvanlaak how about the packagist settings, etc? Should there be some changes, so it doesn't fall apart?

@rvanlaak
Copy link
Owner

Can you add me as maintainer on Packagist first? That way I can make sure to update the reference once the ownership on Github was transferred.

@dmishh
Copy link
Collaborator

dmishh commented Jan 25, 2023

@rvanlaak I just added you to the maintainers list - https://packagist.org/packages/dmishh/settings-bundle

@rvanlaak
Copy link
Owner

Feel free to transfer the repo @dmishh , thanks for your effort!

@dmishh
Copy link
Collaborator

dmishh commented Jan 26, 2023

@rvanlaak you need to delete the repo fork in your account first.
The error I'm getting during the transfer attempt: "rvanlaak/SettingsBundle already exists"

Please, do so and let me know. Thanks

@rvanlaak
Copy link
Owner

Removed my fork ✅

@dmishh
Copy link
Collaborator

dmishh commented Jan 27, 2023

@rvanlaak great! "Repository transfer to rvanlaak requested"

Thanks for supporting the bundle!

@Chris53897
Copy link

Thanks @rvanlaak for takeing over the repo.
Please let us know after the transfer is completed and i hope we get symfony 6 support soon.

@rvanlaak
Copy link
Owner

rvanlaak commented Feb 5, 2023

@dmishh in order to not mess up possible packagist installations (as I was OoO for some days), I've not accepted the transfer yet and it now has expired. Can you resend it?

@dmishh
Copy link
Collaborator

dmishh commented Feb 6, 2023

@rvanlaak yep, I just initiated the transfer again

@rvanlaak
Copy link
Owner

rvanlaak commented Feb 6, 2023

Done! Updated the Packagist settings accordingly and left a note on README for clarity. Thank you @dmishh !

@Chris53897 Chris53897 mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants