Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing relative paths to cargo #1331

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dfaust
Copy link

@dfaust dfaust commented Sep 22, 2023

Make sure these boxes are checked! πŸ“¦βœ…

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ πŸ˜„ Thanks so much for contributing to wasm-pack! πŸ˜„ ✨✨

When building a crate located in a sub-directory, relative paths, passed as extra options to cargo (like --target-dir), are now handled correctly.

This closes issues #704, #1156 and #1252.
And makes PR #712 obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant