Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS Certificate Compression (RFC8879) - v2 #534

Closed

Conversation

sharksforarms
Copy link

@sharksforarms sharksforarms commented Feb 23, 2021

I took a different approach after investigating the bogo tests and boringssl. Previous PR: #445

No longer include compression dependencies and leave this open to the client libraries to use/configure as they wish.

This PR implements RFC8879

Issue: #436

@sharksforarms sharksforarms force-pushed the certificate-compression-v2 branch 2 times, most recently from 310088d to b977575 Compare April 16, 2021 19:20
@sharksforarms
Copy link
Author

Rebased with master to keep this branch up to date

@cpu
Copy link
Member

cpu commented Oct 16, 2023

@sharksforarms Is this branch something you would be interested in rebasing on main and putting up for review?

@sharksforarms
Copy link
Author

@sharksforarms Is this branch something you would be interested in rebasing on main and putting up for review?

Hi @cpu, thanks for taking a look. I'm interested yes. Please advise if the design (callback approach) is still appropriate or if this should change, I'll attempt to rebase but I believe it may be too far gone 😅

@cpu
Copy link
Member

cpu commented Oct 17, 2023

Hi @cpu, thanks for taking a look. I'm interested yes.

Great!

Please advise if the design (callback approach) is still appropriate or if this should change

I haven't had a chance to familiarize myself with RFC 8879, or to read your branch with too much care but I think it's the right place to start. It's possible that @ctz has more existing context/thoughts on the matter.

@sharksforarms
Copy link
Author

sharksforarms commented Feb 5, 2024

I started to re-work on this a while back here: main...sharksforarms:rustls:sharksforarms/cert-compression

If anyone wanted to pick this up, feel free, at the moment I don't have enough time to dedicate to this.

@ctz
Copy link
Member

ctz commented May 16, 2024

I'm going to close this. I will shortly be bringing forward a PR for this, that reuses some parts of this one. Thanks!

@ctz ctz closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants