Smaller misc changes extracted from client-side ECH branch #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
==========================================
- Coverage 95.49% 95.48% -0.02%
==========================================
Files 86 86
Lines 18651 18654 +3
==========================================
Hits 17811 17811
- Misses 840 843 +3 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
May 6, 2024
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
We will want to store this type in configurations that are `Clone` and `Debug`.
The `HpkeSuite` type is small enough to be a candidate for `Copy`. The `HpkePublicKey` type should be `Debug` and `Clone` so we can easily use it for GREASE ECH configurations.
In order to process ECH HRR acceptance it is convenient to be able to clone the `HelloRetryRequest`.
In practice this test is more noisy than useful. This commit relaxes it to only check that the builder types/intermediate states are debug, but not that the debug representation is a byte-for-byte match to an expected value.
|
@ctz I think you reviewed these commits over in the WIP ECH branch. Assuming they're still 👍 to you would you mind stamping? |
ctz
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch pulls out a handful of commits I've been carrying at the head of the WIP client-side ECH branch (#1718). They're all small stand-alone changes that are easy to review/merge ahead of the bulk of the ECH implementation work.