Add support for enforcing CRL expiration #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperpatterson
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
==========================================
+ Coverage 95.48% 95.49% +0.01%
==========================================
Files 86 86
Lines 18664 18709 +45
==========================================
+ Hits 17821 17866 +45
Misses 843 843 ☔ View full report in Codecov by Sentry. |
Just wanted to note IME this job always fails when there's a cargo patch in play, so don't worry about debugging this one. |
cpu
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Thank you, this looks good 🌠
Are you open to adding an integration test for this? There are some existing tests (starting around here) in api.rs.
I don't think it needs to be super extensive. Something like:
- updating test_ca.rs to generate an expired CRL alongside the others
- adding one integration test that uses the default verification behaviour, allowing the expired CRL to be processed without err
- adding one integration test that uses the customized behaviour, verifying the CRL is rejected with the expected err.
|
@cpu Thanks, I've added in this test! 👍 |
cpu
reviewed
May 1, 2024
cpu
reviewed
May 16, 2024
cpu
approved these changes
May 16, 2024
There was a problem hiding this comment.
Looks good to me. Thanks!
Would you mind tidying the commit history? Unless anyone else has an opinion I would vote to do this in two commits: one to land the feature, and one to land the integration test update. It feels worth keeping the two separate in this case since the latter requires a large test-ca diff.
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
ctz
reviewed
May 17, 2024
jasperpatterson
force-pushed
the
jasper/crl-expiration
branch
from
9e09ce6
to
5577cc8
Compare
jasperpatterson
force-pushed
the
jasper/crl-expiration
branch
from
5577cc8
to
62c9d78
Compare
djc
approved these changes
May 21, 2024
ctz
approved these changes
May 21, 2024
This seems to be jammed up. The last job (Build+test (stable, ubuntu-latest)) is completed, but spinning. I'm going to pull it out and requeue and see if that does the trick. |
Looks like there's a broader outage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for enforcing the CRL nextUpdate field (i.e. expiration). The corresponding changes in webpki are here: rustls/webpki#227