Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficient handshake extensions experiment #1475

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Efficient handshake extensions experiment #1475

wants to merge 7 commits into from

Conversation

ctz
Copy link
Member

@ctz ctz commented Sep 14, 2023 •
edited

not worth reviewing yet: CI is unlikely to pass, and i've commented out a slab of tests

this is re #908

@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited

Codecov Report

Attention: Patch coverage is 96.58314% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 95.41%. Comparing base (0398ac5) to head (dc957ec).

Files Patch % Lines
rustls/src/msgs/handshake.rs 96.04% 11 Missing ⚠️
rustls/src/quic.rs 60.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
- Coverage   95.82%   95.41%   -0.42%     
==========================================
  Files          84       84              
  Lines       18865    18934      +69     
==========================================
- Hits        18077    18065      -12     
- Misses        788      869      +81

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz mentioned this pull request Oct 16, 2023
Closed
This was referenced Nov 6, 2023
Closed
Merged
@ctz ctz mentioned this pull request Jan 10, 2024
Merged
@ctz ctz added the performance_enhancement Pull requests that should improve performance label Feb 9, 2024
@ctz ctz mentioned this pull request Feb 28, 2024
Closed
1 task
ctz added 7 commits March 12, 2024 15:36
@ctz
impl Codec for unit type
4243090
@ctz
Avoid handshake message round-tripping for binders
7b33a9a 
Verifying a _received_ `ClientHello` binder should be done
against the original received bytes, not our re-encoding of them.

This previously worked, because we required and tested that
we could round-trip `ClientHello` messages (and others).  This
is about to become not true.
@ctz
Introduce ClientExtensions type
8eff76f 
Instead of `Vec<ClientExtension>`, store the extension data as
a struct.  This is possible because past commits have removed
the need for this us to losslessly round-trip extension data.

This involves fewer allocations to construct the extensions for clients.

It eliminates repeated iteration of the vector to find specific extensions
when processing a `ClientHello` for servers.  It also reduces
the cost of detecting duplicate extensions.
@ctz
Switch from Vec<ClientExtension> to ClientExtensions
4d42cb7
@ctz
Check unknown extensions for duplicates
ff9555a 
_Known_ extensions are already checked by code in the previous commit.
But we also need to check _unknown_ extensions which are otherwise
discarded during decoding.
@ctz
Validate that pre_shared_key extension appears last
823e46c
@ctz
Allow customisation of alert sent for InvalidMessage
dc957ec 
Use this to send the correct alert for InvalidMessage::PreSharedKeyIsNotFinalExtension
@ctz ctz force-pushed the jbp-efficient-extensions-experiment branch from 5bc822b to dc957ec Compare March 13, 2024 13:18
@rustls-benchmarking Rustls Benchmarking
Copy link

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32662089 32415504 ✅ -246585 (-0.75%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32658917 32415628 ✅ -243289 (-0.74%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32456944 32228296 ✅ -228648 (-0.70%) 0.25%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32463985 32235322 ✅ -228663 (-0.70%) 0.49%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32483865 32256491 ✅ -227374 (-0.70%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32642427 32418573 ✅ -223854 (-0.69%) 0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32477830 32257560 ✅ -220270 (-0.68%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32472759 32253866 ✅ -218893 (-0.67%) 0.51%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32618595 32406532 ✅ -212063 (-0.65%) 0.36%
handshake_tickets_ring_1.3_rsa_aes_server 43800597 43528917 ✅ -271680 (-0.62%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32435260 32234752 ✅ -200508 (-0.62%) 0.25%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32608314 32420570 ✅ -187744 (-0.58%) 0.24%
handshake_tickets_ring_1.3_rsa_chacha_server 43706864 43456096 ✅ -250768 (-0.57%) 0.22%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43699779 43461435 ✅ -238344 (-0.55%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43550306 43327548 ✅ -222758 (-0.51%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43548982 43326398 ✅ -222584 (-0.51%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43450432 43229592 ✅ -220840 (-0.51%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43444126 43233230 ✅ -210896 (-0.49%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43745090 43534239 ✅ -210851 (-0.48%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43436575 43228909 ✅ -207666 (-0.48%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43667789 43462885 ✅ -204904 (-0.47%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43526515 43328335 ✅ -198180 (-0.46%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43727376 43536372 ✅ -191004 (-0.44%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4326272 4312265 ✅ -14007 (-0.32%) 0.32%
transfer_no_resume_ring_1.2_rsa_aes_client 57920371 58091616 ⚠️ 171245 (0.30%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68386034 68575309 ⚠️ 189275 (0.28%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58064223 58220479 ⚠️ 156256 (0.27%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57985864 58141781 ⚠️ 155917 (0.27%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57968705 58124571 ⚠️ 155866 (0.27%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58062783 58217507 ⚠️ 154724 (0.27%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58064377 58218138 ⚠️ 153761 (0.26%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4523707 4482336 -41371 (-0.91%) 3.85%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4029901 3996831 -33070 (-0.82%) 3.54%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32658838 32423025 -235813 (-0.72%) 0.74%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12688347 12657227 -31120 (-0.25%) 0.86%
handshake_session_id_ring_1.2_rsa_aes_client 4437782 4427592 -10190 (-0.23%) 0.63%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30232858 30300487 67629 (0.22%) 0.48%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8654809 8673308 18499 (0.21%) 0.61%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12671502 12697834 26332 (0.21%) 0.92%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30473356 30411166 -62190 (-0.20%) 0.36%
handshake_tickets_ring_1.2_rsa_aes_server 4763165 4753868 -9297 (-0.20%) 0.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8663985 8680327 16342 (0.19%) 0.83%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4521244 4513155 -8089 (-0.18%) 0.74%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92430321 92593247 162926 (0.18%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92393075 92552563 159488 (0.17%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92394398 92550609 156211 (0.17%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92398884 92552419 153535 (0.17%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57983042 58077293 94251 (0.16%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92471222 92614763 143541 (0.16%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92454882 92593254 138372 (0.15%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12306043 12291043 -15000 (-0.12%) 0.94%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30303211 30269815 -33396 (-0.11%) 0.22%
handshake_tickets_ring_1.3_rsa_aes_client 42372017 42417801 45784 (0.11%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2129062 2126914 -2148 (-0.10%) 0.35%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30664733 30695065 30332 (0.10%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42312009 42348287 36278 (0.09%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4258795 4255177 -3618 (-0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4183715 4180288 -3427 (-0.08%) 0.69%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1879675 1878153 -1522 (-0.08%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2126581 2124894 -1687 (-0.08%) 0.38%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30479938 30504027 24089 (0.08%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4705898 4702261 -3637 (-0.08%) 0.74%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30259373 30282742 23369 (0.08%) 0.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1883150 1881697 -1453 (-0.08%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4262951 4259732 -3219 (-0.08%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42125539 42156809 31270 (0.07%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 42206936 42238111 31175 (0.07%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30446517 30468563 22046 (0.07%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30264036 30242969 -21067 (-0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42099241 42127235 27994 (0.07%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46266333 46294836 28503 (0.06%) 0.40%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3355751 3357734 1983 (0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42011098 41986577 -24521 (-0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41934088 41909833 -24255 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3338795 3340585 1790 (0.05%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3366601 3368346 1745 (0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42175558 42195866 20308 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30459852 30445388 -14464 (-0.05%) 0.30%
transfer_no_resume_ring_1.2_rsa_aes_server 46169924 46191456 21532 (0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42168354 42185073 16719 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30676270 30688117 11847 (0.04%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3897412 3898871 1459 (0.04%) 0.22%
handshake_no_resume_ring_1.2_rsa_aes_client 4440516 4442160 1644 (0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41921506 41906065 -15441 (-0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46197802 46211204 13402 (0.03%) 0.28%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3151896 3152751 855 (0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46254512 46266675 12163 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30455048 30447305 -7743 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4538019 4539098 1079 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30428143 30435008 6865 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42106404 42115238 8834 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547384 4548333 949 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13735369 13732653 -2716 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291628 46300043 8415 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80442292 80455486 13194 (0.02%) 0.25%
transfer_no_resume_ring_1.3_rsa_aes_server 46290440 46297367 6927 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3344824 3345323 499 (0.01%) 0.27%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46265325 46258473 -6852 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41993784 41987575 -6209 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13737726 13735752 -1974 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80444982 80456521 11539 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80344221 80355393 11172 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12247271 12245585 -1686 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12043837 12042440 -1397 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12237910 12236605 -1305 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3899739 3900089 350 (0.01%) 0.39%
transfer_no_resume_ring_1.3_rsa_chacha_server 80343730 80350870 7140 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80454780 80448379 -6401 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80350733 80354332 3599 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35454833 35456263 1430 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35452587 35453747 1160 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46301495 46301488 -7 (-0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.17 ms 2.10 ms ✅ -0.06 ms (-2.91%) 1.83%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.44 ms 5.29 ms ✅ -0.15 ms (-2.85%) 1.89%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.41 ms 5.27 ms ✅ -0.15 ms (-2.75%) 1.57%
handshake_session_id_ring_1.2_rsa_aes 1.75 ms 1.70 ms ✅ -0.05 ms (-2.68%) 2.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.16 ms 6.01 ms ✅ -0.16 ms (-2.53%) 1.29%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.33 ms 2.27 ms ✅ -0.06 ms (-2.50%) 1.50%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.13 ms 5.98 ms ✅ -0.15 ms (-2.46%) 1.48%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.39 ms 5.26 ms ✅ -0.13 ms (-2.40%) 1.83%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.43 ms 5.30 ms ✅ -0.13 ms (-2.39%) 1.61%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.44 ms 6.29 ms ✅ -0.15 ms (-2.29%) 1.13%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.42 ms 6.27 ms ✅ -0.15 ms (-2.27%) 1.51%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.14 ms 6.01 ms ✅ -0.13 ms (-2.15%) 1.66%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.08 ms 5.96 ms ✅ -0.13 ms (-2.08%) 1.61%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.38 ms 6.26 ms ✅ -0.12 ms (-1.88%) 1.44%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.42 ms 6.30 ms ✅ -0.12 ms (-1.85%) 1.74%
handshake_tickets_ring_1.2_rsa_aes 1.84 ms 1.80 ms ✅ -0.03 ms (-1.84%) 1.69%
handshake_tickets_ring_1.3_rsa_aes 7.57 ms 7.48 ms ✅ -0.09 ms (-1.17%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.93 ms 6.85 ms ✅ -0.08 ms (-1.16%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.51 ms 7.43 ms ✅ -0.08 ms (-1.04%) 1.02%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.85 ms 4.75 ms -0.10 ms (-2.12%) 3.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 479.93 µs 470.39 µs -9.54 µs (-1.99%) 2.51%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.57 ms 5.47 ms -0.11 ms (-1.90%) 3.47%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 479.22 µs 470.50 µs -8.72 µs (-1.82%) 2.81%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.78 ms 5.69 ms -0.09 ms (-1.60%) 3.61%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.79 ms 5.70 ms -0.09 ms (-1.50%) 3.50%
handshake_no_resume_ring_1.3_ecdsap256_aes 510.57 µs 503.41 µs -7.16 µs (-1.40%) 1.85%
handshake_no_resume_ring_1.3_ecdsap256_chacha 509.53 µs 502.41 µs -7.12 µs (-1.40%) 2.12%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.69 ms 6.60 ms -0.09 ms (-1.33%) 3.44%
transfer_no_resume_ring_1.2_rsa_aes 7.15 ms 7.07 ms -0.08 ms (-1.17%) 2.63%
transfer_no_resume_ring_1.3_rsa_aes 7.26 ms 7.18 ms -0.08 ms (-1.16%) 2.47%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.88 ms 6.80 ms -0.08 ms (-1.12%) 1.18%
handshake_session_id_ring_1.3_ecdsap256_aes 6.91 ms 6.84 ms -0.07 ms (-0.99%) 1.08%
handshake_session_id_ring_1.3_rsa_aes 7.55 ms 7.47 ms -0.07 ms (-0.98%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.79 ms 9.70 ms -0.09 ms (-0.96%) 2.66%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.87 ms 6.80 ms -0.07 ms (-0.95%) 1.01%
handshake_session_id_ring_1.3_rsa_chacha 7.50 ms 7.43 ms -0.07 ms (-0.95%) 1.30%
handshake_tickets_ring_1.3_ecdsap384_aes 10.03 ms 9.95 ms -0.09 ms (-0.86%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.17 ms -0.01 ms (-0.79%) 1.10%
handshake_session_id_ring_1.3_ecdsap384_aes 10.01 ms 9.93 ms -0.08 ms (-0.78%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.98 ms 9.90 ms -0.08 ms (-0.77%) 1.12%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.97 ms 9.89 ms -0.08 ms (-0.76%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 14.04 ms 13.95 ms -0.09 ms (-0.66%) 1.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.18 ms -0.01 ms (-0.66%) 1.03%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.35 ms 13.26 ms -0.09 ms (-0.66%) 1.55%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.34 ms 13.26 ms -0.08 ms (-0.60%) 1.33%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.08 ms -0.01 ms (-0.57%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.92 ms 13.84 ms -0.08 ms (-0.55%) 1.53%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.28 ms 14.20 ms -0.08 ms (-0.54%) 1.33%
handshake_no_resume_ring_1.3_rsa_aes 1.09 ms 1.08 ms -0.01 ms (-0.51%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.45 ms 16.37 ms -0.08 ms (-0.50%) 1.19%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.40 ms -0.01 ms (-0.47%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.41 ms -0.01 ms (-0.46%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.01 ms (-0.45%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.62 ms 3.60 ms -0.01 ms (-0.32%) 1.07%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.62 ms 3.61 ms -0.01 ms (-0.30%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.29%) 1.00%

Additional information

Historical results

Checkout details:

@hellais hellais mentioned this pull request May 1, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance_enhancement Pull requests that should improve performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ctz