use full range by default for yuv420p if supported #6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Explicitly specify the color space as bt601 2. Use fullrange by default for yuv420p if supported 3. Use the pix_fmt space range format to identify codec capabilities, make i444 proto field deprecated, and cause the non-release version of 444 true color to fail. Signed-off-by: 21pages <pages21@163.com>
21pages
changed the title
rustdesk
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6518
After the change, all colors in the image below are accurate for VP9 420 and AV1 420, but still inaccurate when r,g,b are not equal.
The conversion between yuv and rgb is irreversible, so there will be a loss of accuracy.
Teamviewer and parsec are inaccurate in both cases, anydesk accurate in both cases.
tested all codecs, 1.2.4->1.2.3, 1.2.3->1.2.4 on windows.