Add bernoulli naive bayes implementation #242
Conversation
not sure which dependency causes this issue |
Codecov ReportBase: 55.59% // Head: 55.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 55.59% 55.52% -0.07%
==========================================
Files 96 98 +2
Lines 8951 9042 +91
==========================================
+ Hits 4976 5021 +45
- Misses 3975 4021 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Seems like we need to bump MSRV to 1.59 (or limit the |
| let thr = self.binarize.unwrap_or_else(F::zero); | ||
| let xbin = x.map(|v| if v > &thr { F::one() } else { F::zero() }); | ||
| if self.binarize.is_some() { | ||
| CowArray::from(xbin) | ||
| } else { | ||
| CowArray::from(x) | ||
| } |
There was a problem hiding this comment.
Can you write the logic like:
if let Some(thr) = self.binarize {
...
} else {
...
}
| // Threshold for binarization | ||
| binarize: Option<F>, | ||
| // Phantom data for label type | ||
| label: PhantomData<L>, |
There was a problem hiding this comment.
Do we need this phantomdata?
Continuation of #226