Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs of linfa-hierarchical #146

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bytesnake
Copy link
Member

The interface and documentation of linfa-hierarchical is not updated in a long time. This PR adds the example to the documentation and changes the implementation of transform to predict, which is more correct in this context.

Currently blocked on a cyclic dependency caused by implementing linfa::Predict for linfa::PredictRef with kernel data. A workaround is by adding a feature flag to linfa-kernel which removes all linfa related parts and including that into the dependency tree for linfa.

@bytesnake bytesnake marked this pull request as draft July 17, 2021 18:33
@YuhanLiin
Copy link
Collaborator

Why do we need to reverse the dependency between linfa and linfa-kernel?

@bytesnake
Copy link
Member Author

to use the Kernel structure in the implementation of Predict for T where T: PredictRef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants