Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all_fruits_types_in_basket to fail if all fruit kinds are not included #1782

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielsomerfield
Copy link

This is a redo of PR #1626 which I flaked on. This accounts for the new file structure and the formatting request.

@@ -27,6 +27,14 @@ enum Fruit {
Pineapple,
}

const FRUIT_KINDS: [Fruit; 5] = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be in the test module, and there's no reason to have this be an array when it could be a Vec<Fruit> instead

@mo8it
Copy link
Contributor

mo8it commented Mar 27, 2024

@danielsomerfield Could you please apply the requested changes so that I can merge? :D

@danielsomerfield
Copy link
Author

Sorry, wasn't getting emails until recently.

I can't move it into the test mod as both a const and a vec, but I could push it into the test function as a vec. Let me know if that is ok. Otherwise, I believe it has to be an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants