Fix all_fruits_types_in_basket to fail if all fruit kinds are not included #1782
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exercises/11_hashmaps/hashmaps2.rs
Outdated
| @@ -27,6 +27,14 @@ enum Fruit { | |||
| Pineapple, | |||
| } | |||
|
|
|||
| const FRUIT_KINDS: [Fruit; 5] = [ | |||
There was a problem hiding this comment.
this can be in the test module, and there's no reason to have this be an array when it could be a Vec<Fruit> instead
|
@danielsomerfield Could you please apply the requested changes so that I can merge? :D |
|
Sorry, wasn't getting emails until recently. I can't move it into the test mod as both a const and a vec, but I could push it into the test function as a vec. Let me know if that is ok. Otherwise, I believe it has to be an array. |
|
Hi, when will this be merged? I just stumbled over the same "issue". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of PR #1626 which I flaked on. This accounts for the new file structure and the formatting request.