Correct an example #1940
Open
Correct an example #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function, as written, is not valid. `a` is not bounded. Given the parameter and the return type, I assume we are considering the identity function for u32. In this case, the return value should be `b`. As I was touching this code, I considered also changing the function name, for the sake of the clarity.
jieyouxu
reviewed
Apr 6, 2024
Comment on lines
7
to
9
| // ^^ ^early bound | ||
| // ^^ | ||
| // ^^late bound |
There was a problem hiding this comment.
Could you also fix the alignment of the ^^s?
camelid
added
the
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function, as written, is not valid.
ais not bounded. Given the parameter and the return type, I assume we are considering the identity function for u32. In this case, the return value should beb. As I was touching this code, I considered also changing the function name, for the sake of the clarity.