[stable] Cherry-pick LLVM fix for 1.41.1 #69444
Conversation
|
@bors r+ p=1000 Pre-approving this to get dev artifacts up as soon as possible. Even if this PR merges and we then decide not to go with this approach, we can always do the release with the previously built artifacts. @rust-lang/compiler @rust-lang/release the reasoning for this LLVM backport is explained at #69225 (comment). Part of release team discussed this on Discord and agree we should want this, but we should get wider consensus before deciding to actually ship the changes merged by this PR. r? @Mark-Simulacrum |
|
📌 Commit acb2399 has been approved by |
bors
added
the
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors treeclosed=100 |
This comment has been minimized.
This comment has been minimized.
|
☀️ Test successful - checks-azure |
Cherry-pick the LLVM fix for #69225 An additional reproducer was provided in #69225 -- the new testcase here -- which still crashes even after #69241 reverted #67174. Now this pull request updates LLVM with the cherry-picked reversion of its own. This is also going to stable in #69444. I have not tried to reapply #67174 yet -- cc @kraai @shahn
I'm a little confused about the current status on this. Do you have consensus on which version will actually be shipped? By the way, I really appreciate the hard work that went into rebuilding the release at the last minute. Sorry for messing with your sleep schedules. 🙁 |
|
We're currently planning on releasing the new version (i.e., with the LLVM backport). |
This PR cherry-picks the LLVM patch required to properly fix #69225 on 1.41.1, and adds a test to make sure the fix works.
r? @ghost