Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reborrow Pin<P> using &mut in Pin::set #57419

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Reborrow Pin<P> using &mut in Pin::set #57419

merged 1 commit into from
Jan 9, 2019

Conversation

cramertj
Copy link
Member

@cramertj cramertj commented Jan 7, 2019

Fixes #57339.

This makes it possible to call .set multiple times without
using .as_mut() first to reborrow the pointer.

r? @withoutboats
cc @rust-lang/libs

@cramertj
Reborrow Pin<P> using &mut in Pin::set
68e98a2 
This makes it possible to call `.set` multiple times without
using `.as_mut()` first to reborrow the pointer.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 7, 2019
@withoutboats
Copy link
Contributor

@bors r=me

This needs to be backported to beta, I'm not sure about the procedure here.

@alexcrichton
Copy link
Member

@bors: r=withouboats

@bors
Copy link
Contributor

bors commented Jan 7, 2019

📌 Commit 68e98a2 has been approved by withouboats

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2019
@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2019
@dtolnay
Copy link
Member

dtolnay commented Jan 7, 2019

@bors r=withoutboats

@Centril
Copy link
Contributor

Centril commented Jan 9, 2019

@bors p=1

Giving prio to make sure this lands since it's beta-nominated/accepted and beta=>stable happens soon.

@bors
Copy link
Contributor

bors commented Jan 9, 2019

⌛ Testing commit 68e98a2 with merge 6ecad33...

bors added a commit that referenced this pull request Jan 9, 2019
@bors
Auto merge of #57419 - cramertj:pin-set, r=withouboats
6ecad33 
Reborrow Pin<P> using &mut in `Pin::set`

Fixes #57339.

This makes it possible to call `.set` multiple times without
using `.as_mut()` first to reborrow the pointer.

r? @withoutboats
cc @rust-lang/libs
@bors
Copy link
Contributor

bors commented Jan 9, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: withouboats
Pushing 6ecad33 to master...

@bors bors merged commit 68e98a2 into rust-lang:master Jan 9, 2019
@cramertj cramertj deleted the pin-set branch January 9, 2019 16:56
@Centril Centril removed beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jan 9, 2019
@Centril
Copy link
Contributor

Centril commented Jan 9, 2019

I think there was some confusion here.. Pin<T> is stabilized in 1.33 but the master=>beta promotion for 1.33 hasn't happened yet (on the 15th of January), thus there's nothing to backport as far as I can see.

@alexcrichton
Copy link
Member

Oops my bad, can confirm nothing needed for a backport!

@taiki-e taiki-e mentioned this pull request Jan 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@withoutboats withoutboats

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cramertj @withoutboats @alexcrichton @bors @dtolnay @Centril @rust-highfive