Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert clamp #44438

Merged
merged 6 commits into from Sep 9, 2017
Merged

Revert clamp #44438

merged 6 commits into from Sep 9, 2017

Conversation

Xaeroxe
Copy link
Contributor

@Xaeroxe Xaeroxe commented Sep 8, 2017 •
edited

Revert clamp per #44095 (comment) while we take time to assess the potential backwards compatibility damage done by it.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Xaeroxe Xaeroxe mentioned this pull request Sep 8, 2017
Closed
3 tasks
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1 (undoing a regression)

@bors
Copy link
Contributor

bors commented Sep 8, 2017

📌 Commit db5b5f9 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Sep 9, 2017

⌛ Testing commit db5b5f9 with merge 929b878...

bors added a commit that referenced this pull request Sep 9, 2017
@bors
Auto merge of #44438 - Xaeroxe:clamp, r=Mark-Simulacrum
929b878 
Revert clamp

Revert clamp per #44095 (comment) while we take time to assess the potential backwards compatibility damage done by it.
@bors
Copy link
Contributor

bors commented Sep 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 929b878 to master...

@bors bors merged commit db5b5f9 into rust-lang:master Sep 9, 2017
@Xaeroxe Xaeroxe deleted the clamp branch September 9, 2017 23:26
@scottmcm scottmcm mentioned this pull request Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Xaeroxe @rust-highfive @Mark-Simulacrum @bors @nikomatsakis