Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Weak::new_downgraded() (#30425) #30467

Merged
merged 7 commits into from Dec 30, 2015
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 37 additions & 1 deletion src/liballoc/rc.rs
Expand Up @@ -160,7 +160,7 @@ use core::cell::Cell;
use core::cmp::Ordering;
use core::fmt;
use core::hash::{Hasher, Hash};
use core::intrinsics::{assume, abort};
use core::intrinsics::{assume, abort, uninit};
use core::marker;
#[cfg(not(stage0))]
use core::marker::Unsize;
Expand Down Expand Up @@ -830,6 +830,36 @@ impl<T: ?Sized + fmt::Debug> fmt::Debug for Weak<T> {
}
}

impl<T> Weak<T> {
/// Constructs a new `Weak<T>` without an accompanying instance of T.
///
/// This allocates memory for T, but does not initialize it. Calling
/// Weak<T>::upgrade() on the return value always gives None.
///
/// # Examples
///
/// ```
/// use std::rc::Weak;
///
/// let five = Weak::new_downgraded();
/// ```

#[unstable(feature = "downgraded_weak",
reason = "recently added",
issue="30425")]
pub fn new_downgraded() -> Weak<T> {
unsafe {
Weak {
_ptr: Shared::new(Box::into_raw(box RcBox {
strong: Cell::new(0),
weak: Cell::new(1),
value: uninit(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use core::mem::uninitialized instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing

})),
}
}
}
}

// NOTE: We checked_add here to deal with mem::forget safety. In particular
// if you mem::forget Rcs (or Weaks), the ref-count can overflow, and then
// you can free the allocation while outstanding Rcs (or Weaks) exist.
Expand Down Expand Up @@ -1122,6 +1152,12 @@ mod tests {
let foo_rc = Rc::from(foo);
assert!(123 == *foo_rc);
}

#[test]
fn test_new_downgraded() {
let foo: Weak<usize> = Weak::new_downgraded();
assert!(foo.upgrade().is_none());
}
}

#[stable(feature = "rust1", since = "1.0.0")]
Expand Down