Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #123029

Merged
merged 17 commits into from Mar 25, 2024
Merged

Rollup of 7 pull requests #123029

merged 17 commits into from Mar 25, 2024

Commits on Mar 24, 2024

  1. Clarify transmute example

    SkiFire13 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    fb65ca1 View commit details
    Browse the repository at this point in the history
  2. Clean up unnecessary headers/flags in coverage mir-opt tests

    These headers and flags were historically needed, but are now unnecessary due
    to various changes in how coverage information is stored in MIR.
    Zalathar committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    b5ee20f View commit details
    Browse the repository at this point in the history
  3. CFI: Handle dyn with no principal

    In user-facing Rust, `dyn` always has at least one predicate following
    it. Unfortunately, because we filter out marker traits from receivers at
    callsites and `dyn Sync` is, for example, legal, this results in us
    having `dyn` types with no predicates on occasion in our alias set
    encoding. This patch handles cases where there are no predicates in a
    `dyn` type which are relevant to its alias set.
    
    Fixes rust-lang#122998
    maurer committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    ea45185 View commit details
    Browse the repository at this point in the history
  4. CFI: Support arbitrary receivers

    Previously, we only rewrote `&self` and `&mut self` receivers. By
    instantiating the method from the trait definition, we can make this
    work work with arbitrary legal receivers instead.
    maurer committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    40f41e7 View commit details
    Browse the repository at this point in the history
  5. Temporarily remove nnethercote from the review rotation.

    I will be on vacation for the next three weeks. I will re-add myself
    when I return.
    nnethercote committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    50b49ae View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Inline and remove Parser::parse_expr_tuple_field_access_float.

    It has a single call site, and afterwards all the calls to
    `parse_expr_tuple_field_access` are in a single method, which is nice.
    nnethercote committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    42066b0 View commit details
    Browse the repository at this point in the history
  2. Remove next_token handling from parse_expr_tuple_field_access.

    It's clearer at the call site.
    nnethercote committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    90eeb3d View commit details
    Browse the repository at this point in the history
  3. Change parse_expr_tuple_field_access.

    Pass in the span for the field rather than using `prev_token`.
    Also rename it `mk_expr_tuple_field_access`, because it doesn't do any
    actual parsing, it just creates an expression with what it's given.
    
    Not much of a clarity win by itself, but unlocks additional subsequent
    simplifications.
    nnethercote committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9c09116 View commit details
    Browse the repository at this point in the history
  4. Clarify parse_dot_suffix_expr.

    For the `MiddleDot` case, current behaviour:
    - For a case like `1.2`, `sym1` is `1` and `sym2` is `2`, and `self.token`
      holds `1.2`.
    - It creates a new ident token from `sym1` that it puts into `self.token`.
    - Then it does `bump_with` with a new dot token, which moves the `sym1`
      token into `prev_token`.
    - Then it does `bump_with` with a new ident token from `sym2`, which moves the
      `dot` token into `prev_token` and discards the `sym1` token.
    - Then it does `bump`, which puts whatever is next into `self.token`,
      moves the `sym2` token into `prev_token`, and discards the `dot` token
      altogether.
    
    New behaviour:
    - Skips creating and inserting the `sym1` and dot tokens, because they are
      unnecessary.
    - This also demonstrates that the comment about `Spacing::Alone` is
      wrong -- that value is never used. That comment was added in rust-lang#77250,
      and AFAICT it has always been incorrect.
    
    The commit also expands comments. I found this code hard to read
    previously, the examples in comments make it easier.
    nnethercote committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    dce0f7f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1bbab71 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#122858 - nnethercote:tweak-parse_dot_suffix…

    …_expr, r=est31
    
    Tweak `parse_dot_suffix_expr`
    
    I find this function hard to understand, so I rewrote it.
    
    r? ```@est31```
    matthiaskrgr committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    4cae68b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#122982 - Zalathar:bootstrap-coverage-docs, …

    …r=onur-ozkan
    
    Add more comments to the bootstrap code that handles `tests/coverage`
    
    At the bootstrap level, coverage tests are a bit more complicated than other test suites, because we want to run the same set of test files in multiple different modes, in a way that's convenient and flexible when invoked manually.
    
    This PR adds a few more comments to explain what's going on.
    matthiaskrgr committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    fbb81fa View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#122990 - SkiFire13:transmute-may-copy, r=jh…

    …pratt
    
    Clarify transmute example
    
    The example claims using an iterator will copy the entire vector, but this is not true in practice thanks to internal specializations in the stdlib (see https://godbolt.org/z/cnxo3MYs5 for confirmation that this doesn't reallocate nor iterate over the vec's elements). Since neither the copy nor the optimization is guaranteed I opted for saying that they _may_ happen.
    matthiaskrgr committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e3fbaa8 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#122995 - Zalathar:flags-mir-opt, r=Mark-Sim…

    …ulacrum
    
    Clean up unnecessary headers/flags in coverage mir-opt tests
    
    During rust-lang#122542, I noticed that some of the headers and flags I had copied over from `tests/mir-opt/instrument_coverage.rs`  were unnecessary. And while working to remove those, I noticed even more that could be removed or replaced.
    matthiaskrgr committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    d1fca06 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#123003 - maurer:dyn-empty, r=compiler-errors

    CFI: Handle dyn with no principal
    
    In user-facing Rust, `dyn` always has at least one predicate following it. Unfortunately, because we filter out marker traits from receivers at callsites and `dyn Sync` is, for example, legal, this results in us having `dyn` types with no predicates on occasion in our alias set encoding. This patch handles cases where there are no predicates in a `dyn` type which are relevant to its alias set.
    
    Fixes rust-lang#122998
    
    r? workingjubilee
    matthiaskrgr committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    84ec66e View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#123005 - maurer:cfi-arbitrary-receivers, r=…

    …compiler-errors
    
    CFI: Support complex receivers
    
    Right now, we only support rewriting `&self` and `&mut self` into `&dyn MyTrait` and `&mut dyn MyTrait`. This expands it to handle the full gamut of receivers by calculating the receiver based on *substitution* rather than based on a rewrite. This means that, for example, `Arc<Self>` will become `Arc<dyn MyTrait>` appropriately with this change.
    
    This approach also allows us to support associated type constraints as well, so we will correctly rewrite `&self` into `&dyn MyTrait<T=i32>`, for example.
    
    r? ```@workingjubilee```
    matthiaskrgr committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    fe0222b View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#123020 - nnethercote:rm-nnethercote-review,…

    … r=nnethercote
    
    Temporarily remove nnethercote from the review rotation.
    
    I will be on vacation for the next three weeks. I will re-add myself when I return.
    
    r? `@nnethercote`
    matthiaskrgr committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ab8084a View commit details
    Browse the repository at this point in the history