Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #122869

Merged
merged 31 commits into from Mar 22, 2024
Merged

Rollup of 9 pull requests #122869

merged 31 commits into from Mar 22, 2024

Commits on Mar 6, 2024

  1. Add postfix-match experimental feature

    Co-authored-by: Josh Stone <jistone@redhat.com>
    RossSmyth and cuviper committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    68a58f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78b3bf9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d4ba888 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    567c98b View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. interpret/allocation: fix aliasing issue in interpreter and refactor …

    …getters a bit
    
    - rename mutating functions to be more scary
    - add a new raw bytes getter
    RalfJung committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7be47b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Gracefully handle AnonConst in diagnostic_hir_wf_check()

    when it is the default value of a generic param
    gurry committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3c70d60 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    4250216 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Configuration menu
    Copy the full SHA
    1cf345e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cda209b View commit details
    Browse the repository at this point in the history
  3. Sorting arbitrary constants should not be done, as it relies on `DefI…

    …d` ordering, which breaks incremental compilation.
    oli-obk committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    d8470bb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    60891ca View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5425338 View commit details
    Browse the repository at this point in the history
  6. Not insta-stable

    zachs18 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    1b95760 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Fix Itanium mangling usizes

    Arrays, surprisingly, are not sized to u64 on all platforms.
    workingjubilee committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    861e470 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1bcbed1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4d9ce7a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b57403 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d7e166d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b0e1008 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bd2d70d View commit details
    Browse the repository at this point in the history
  8. coverage: Clean up marker statements that aren't needed later

    Some of the marker statements used by coverage are added during MIR building
    for use by the InstrumentCoverage pass (during analysis), and are not needed
    afterwards.
    Zalathar committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    91aae58 View commit details
    Browse the repository at this point in the history
  9. address review comments

    matthiaskrgr committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e68cb00 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#121619 - RossSmyth:pfix_match, r=petrochenkov

    Experimental feature postfix match
    
    This has a basic experimental implementation for the RFC postfix match (rust-lang/rfcs#3295, rust-lang#121618). [Liaison is](https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Postfix.20Match.20Liaison/near/423301844) ```@scottmcm``` with the lang team's [experimental feature gate process](https://github.com/rust-lang/lang-team/blob/master/src/how_to/experiment.md).
    
    This feature has had an RFC for a while, and there has been discussion on it for a while. It would probably be valuable to see it out in the field rather than continue discussing it. This feature also allows to see how popular postfix expressions like this are for the postfix macros RFC, as those will take more time to implement.
    
    It is entirely implemented in the parser, so it should be relatively easy to remove if needed.
    
    This PR is split in to 5 commits to ease review.
    
    1. The implementation of the feature & gating.
    2. Add a MatchKind field, fix uses, fix pretty.
    3. Basic rustfmt impl, as rustfmt crashes upon seeing this syntax without a fix.
    4. Add new MatchSource to HIR for Clippy & other HIR consumers
    matthiaskrgr committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    783778c View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#122370 - gurry:122199-ice-unexpected-node, …

    …r=davidtwco
    
    Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()`
    
    Instead of running the WF check on the `AnonConst` itself we run it on the `ty` of the generic param of which the `AnonConst` is the default value.
    
    Fixes rust-lang#122199
    matthiaskrgr committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f5ac009 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#122537 - RalfJung:interpret-allocation, r=o…

    …li-obk
    
    interpret/allocation: fix aliasing issue in interpreter and refactor getters a bit
    
    That new raw getter will be needed to let Miri pass pointers to natively executed FFI code ("extern-so" mode).
    
    While doing that I realized our get_bytes_mut are named less scary than get_bytes_unchecked so I rectified that. Also I realized `mem_copy_repeatedly` would break if we called it for multiple overlapping copies so I made sure this does not happen.
    
    And I realized that we are actually [violating Stacked Borrows in the interpreter](https://rust-lang.zulipchat.com/#narrow/stream/136281-t-opsem/topic/I.20think.20Miri.20violates.20Stacked.20Borrows.20.F0.9F.99.88).^^ That was introduced in rust-lang#87777.
    
    r? ```@oli-obk```
    matthiaskrgr committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    84e55be View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#122542 - Zalathar:cleanup, r=oli-obk

    coverage: Clean up marker statements that aren't needed later
    
    Some of the marker statements used by coverage are added during MIR building for use by the InstrumentCoverage pass (during analysis), and are not needed afterwards.
    
    ```@rustbot``` label +A-code-coverage
    matthiaskrgr committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e13c40c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#122800 - zachs18:nonnull-slice-is_empty, r=…

    …Amanieu
    
    Add `NonNull::<[T]>::is_empty`.
    
    As per rust-lang#71146 (comment)
    
    I figured this should be fine to be insta-stable (with an FCP), but I can edit if that is not desired.
    
    r? ```@Amanieu```
    matthiaskrgr committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    ef4a64b View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#122820 - oli-obk:no_ord_def_id, r=estebank

    Stop using `<DefId as Ord>` in various diagnostic situations
    
    work towards rust-lang#90317
    
    Reverts part of rust-lang#106281, as it sorts constants and that's problematic since it can contain `ParamConst`, which contains `DefId`s
    matthiaskrgr committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    7481c0e View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#122847 - workingjubilee:suggest-rust-min-st…

    …ack-workaround-on-overflow, r=TaKO8Ki
    
    Suggest `RUST_MIN_STACK` workaround on overflow
    
    For some Rust crates, like p384, we can't do a whole lot about it even if the stack overflow is reported like in rust-lang#122357 because the problem may be inside LLVM or another codegen backend. We can, however, suggest people set a new `RUST_MIN_STACK` value while handling the SIGSEGV, as that stack-setting will carry forward into the dylib.
    
    As a bonus, this also leads to cleaning up the stack-setting code a bit.
    matthiaskrgr committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b317cda View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#122855 - workingjubilee:mangle-64-bit-chauv…

    …inism, r=compiler-errors
    
    Fix Itanium mangling usizes
    
    Arrays, surprisingly, are not sized to u64 on all platforms.
    
    Fixes rust-lang#122851.
    
    r? ```@compiler-errors```
    
    cc ```@maurer```
    matthiaskrgr committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    3164a47 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a5de4fb View commit details
    Browse the repository at this point in the history