Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #122653

Merged
merged 19 commits into from Mar 17, 2024
Merged

Rollup of 6 pull requests #122653

merged 19 commits into from Mar 17, 2024

Commits on Mar 17, 2024

  1. Configuration menu
    Copy the full SHA
    36f8d67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0437a0c View commit details
    Browse the repository at this point in the history
  3. add test for rust-lang#122301 to cover behavior that's on stable

    if this ought to be broken it should at least happen intentionally
    the8472 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    fefd06d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    772d859 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    60de755 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bdab02c View commit details
    Browse the repository at this point in the history
  7. Mark UEFI std support as WIP

    Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
    Ayush1325 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    c1cf422 View commit details
    Browse the repository at this point in the history
  8. Add release notes for 1.77.0

    cuviper committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    01864e2 View commit details
    Browse the repository at this point in the history
  9. Apply suggestions from code review

    Co-authored-by: Urgau <3616612+Urgau@users.noreply.github.com>
    Co-authored-by: Michael Howell <michael@notriddle.com>
    3 people committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    0ac3d4d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    213e598 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4a2f0f6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8953306 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    87c9349 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#120640 - Ayush1325:uefi-doc, r=Nilstrieb

    Mark UEFI std support as WIP
    
    Currently stdio and alloc support is present with open PRs for some of the other portions.
    
    A prototype of almost all of std support can be found [here](https://github.com/tianocore/rust/tree/uefi-master). I will be up-streaming as much stuff as possible from there.
    matthiaskrgr committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    3d1b04e View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#121862 - cuviper:relnotes-1.77.0, r=Mark-Si…

    …mulacrum
    
    Add release notes for 1.77.0
    
    cc `@rust-lang/release`
    r? `@Mark-Simulacrum`
    matthiaskrgr committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    5c761d8 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#122572 - the8472:test-const-deadness, r=Ral…

    …fJung
    
    add test for rust-lang#122301 to cover behavior that's on stable
    
    If this ought to be broken it should at least happen intentionally
    
    See rust-lang#122301
    matthiaskrgr committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    3fbe203 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#122578 - jieyouxu:guard-decorate, r=fee1-dead

    Only invoke `decorate` if the diag can eventually be emitted
    
    Lints can call [`trimmed_def_paths`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/print/fn.trimmed_def_paths.html#), such as through manual implementations of `LintDiagnostic` and calling `def_path_str`.
    
    https://github.com/rust-lang/rust/blob/05a2be3def211255dc7640b006ac10f0f02baf5c/compiler/rustc_lint/src/lints.rs#L1834-L1839
    
    The emission of a lint eventually relies on [`TyCtxt::node_lint`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/context/struct.TyCtxt.html#method.node_lint), which has a `decorate` closure which is responsible for decorating the diagnostic with "lint stuff". `node_lint` in turn relies on [`lint_level`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/lint/fn.lint_level.html). Within `lint_level`, `decorate` is eventually called just before `Diag::emit` is called to decorate the diagnostic. However, if `-A warnings` or `--cap-lint=allow` are set, or if the unused_must_use lint is explicitly allowed, then `decorate` would be called, which would call `def_path_str`, but the diagnostic would never be emitted and hence would trigger the `must_produce_diag` ICE.
    
    To avoid calling `decorate` when we don't eventually emit the diagnostic, we check that:
    
    - if `--force-warn` is specified, then call `decorate`; otherwise
    - if we can emit warnings (or higher), then call `decorate`.
    
    Fixes rust-lang#121774.
    matthiaskrgr committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    8e748c0 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#122615 - Zalathar:triagebot, r=Mark-Simulacrum

    Mention Zalathar for coverage changes
    
    Hopefully I don't regret all the extra notifications. 🤞
    matthiaskrgr committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    0589ffb View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#122636 - matthiaskrgr:compl3, r=compiler-er…

    …rors
    
    some minor code simplifications
    matthiaskrgr committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    1588d9b View commit details
    Browse the repository at this point in the history