Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build a broken/untested profiler runtime on mingw targets #122613

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Don't build a broken/untested profiler runtime on mingw targets #122613

wants to merge 5 commits into from
+11 −46

Commits on May 3, 2024

  1. Use -Zno-profiler-runtime instead of //@ needs-profiler-support 

    For PGO/coverage tests that don't need to build or run an actual artifact, we
can use `-Zno-profiler-runtime` to run the test even when the profiler runtime
is not available.
    @Zalathar
    Zalathar committed May 3, 2024
    Copy the full SHA
    34f5287 View commit details
    Browse the repository at this point in the history

  2. Don't build a known-broken profiler runtime in x86_64-mingw

    @Zalathar
    Zalathar committed May 3, 2024
    Copy the full SHA
    5f9f732 View commit details
    Browse the repository at this point in the history

  3. Remove //@ ignore-windows-gnu from tests that need the profiler 

    The profiler runtime is no longer built in mingw test jobs, so these tests
should naturally be skipped by `//@ needs-profiler-support`.
    @Zalathar
    Zalathar committed May 3, 2024
    Copy the full SHA
    3dc5ecb View commit details
    Browse the repository at this point in the history

  4. Remove broken/untested --enable-profiler from mingw dist builds

    @Zalathar
    Zalathar committed May 3, 2024
    Copy the full SHA
    7408ace View commit details
    Browse the repository at this point in the history

  5. Add missing revision mcdc to a coverage test 

    This test has header directives that refer to revision `[mcdc]`, which was
never actually declared in the revisions line.
    @Zalathar
    Zalathar committed May 3, 2024
    Copy the full SHA
    c333428 View commit details
    Browse the repository at this point in the history