-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #121897
Rollup of 6 pull requests #121897
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c41af2 - Browse repository at this point
Copy the full SHA 7c41af2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c84ba23 - Browse repository at this point
Copy the full SHA c84ba23View commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 45ca53f - Browse repository at this point
Copy the full SHA 45ca53fView commit details
Commits on Mar 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6cb0c40 - Browse repository at this point
Copy the full SHA 6cb0c40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6136997 - Browse repository at this point
Copy the full SHA 6136997View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f7b14e - Browse repository at this point
Copy the full SHA 0f7b14eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37bbed1 - Browse repository at this point
Copy the full SHA 37bbed1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a92e36 - Browse repository at this point
Copy the full SHA 7a92e36View commit details
Commits on Mar 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 624f9d3 - Browse repository at this point
Copy the full SHA 624f9d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec5e2dc - Browse repository at this point
Copy the full SHA ec5e2dcView commit details -
The ordinary lowering of
thir::ExprKind::Let
is unreachableAfter desugaring, `let` expressions should only appear inside `if` expressions or `match` guards, possibly nested within a let-chain. In both cases they are specifically handled by the lowerings of those expressions, so this case is currently unreachable.
Configuration menu - View commit details
-
Copy full SHA for 972d8da - Browse repository at this point
Copy the full SHA 972d8daView commit details -
Rollup merge of rust-lang#121194 - beetrees:rustc-raw-args, r=petroch…
…enkov Refactor pre-getopts command line argument handling Rebased version of rust-lang#111658. I've also fixed the Windows CI failure (although I don't have access to Windows to test it myself).
Configuration menu - View commit details
-
Copy full SHA for 49775dd - Browse repository at this point
Copy the full SHA 49775ddView commit details -
Rollup merge of rust-lang#121666 - ChrisDenton:thread-name, r=cuviper
Use the OS thread name by default if `THREAD_INFO` has not been initialized Currently if `THREAD_INFO` hasn't been initialized then the name will be set to `None`. This PR changes it to use the OS thread name by default. This mostly affects foreign threads at the moment but we could expand this to make more use of the OS thread name in the future. Note: I've only implemented `Thread::get_name` for windows, linux and macos (and macos adjacent) targets. The rest just return `None`.
Configuration menu - View commit details
-
Copy full SHA for 1af11b1 - Browse repository at this point
Copy the full SHA 1af11b1View commit details -
Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=Ch…
…risDenton Move thread local implementation to `sys` Part of rust-lang#117276.
Configuration menu - View commit details
-
Copy full SHA for 26bac2a - Browse repository at this point
Copy the full SHA 26bac2aView commit details -
Rollup merge of rust-lang#121759 - RalfJung:addr_of, r=the8472
attempt to further clarify addr_of docs
Configuration menu - View commit details
-
Copy full SHA for a7d9522 - Browse repository at this point
Copy the full SHA a7d9522View commit details -
Rollup merge of rust-lang#121888 - cppcoffee:style, r=Nilstrieb
style library/core/src/error.rs Add an extra blank line for clarity in distinguishing implementations.
Configuration menu - View commit details
-
Copy full SHA for e5efece - Browse repository at this point
Copy the full SHA e5efeceView commit details -
Rollup merge of rust-lang#121892 - Zalathar:expr-kind-let, r=Nadrieril
The ordinary lowering of `thir::ExprKind::Let` is unreachable After desugaring, `let` expressions should only appear inside `if` expressions or `match` guards, possibly nested within a let-chain. In both cases they are specifically handled by the lowerings of those expressions, so this case is currently unreachable. --- Context: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Lowering.20of.20.60thir.3A.3AExprKind.3A.3ALet.60.20is.20unreachable My conclusions are partly based on the observation that stubbing out this match arm doesn't cause any test failures. So either this really is unreachable, or it can be reached in some obscure circumstances that our test suite doesn't cover. If we end up needing this code (or something like it) for an implementation of rust-lang/rfcs#3573, it should be easy enough to pull it back out of version control history. I looked into having the `if`/`match` lowerings call back into `expr_into_dest`, but from what I can tell that won't work well, because there are extra scoping considerations that require some awareness of the enclosing if/match. r? ``@Nadrieril``
Configuration menu - View commit details
-
Copy full SHA for 6eaf971 - Browse repository at this point
Copy the full SHA 6eaf971View commit details