-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #121896
Rollup of 10 pull requests #121896
Commits on Mar 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 624f9d3 - Browse repository at this point
Copy the full SHA 624f9d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec5e2dc - Browse repository at this point
Copy the full SHA ec5e2dcView commit details -
The ordinary lowering of
thir::ExprKind::Let
is unreachableAfter desugaring, `let` expressions should only appear inside `if` expressions or `match` guards, possibly nested within a let-chain. In both cases they are specifically handled by the lowerings of those expressions, so this case is currently unreachable.
Configuration menu - View commit details
-
Copy full SHA for 972d8da - Browse repository at this point
Copy the full SHA 972d8daView commit details -
Rollup merge of rust-lang#109263 - squell:master, r=cuviper
fix typo in documentation for std::fs::Permissions Please check and re-check this PR carefully to see if I got this right. But by my logic, if the `read_only` function returns `true`, I would not expect be able to write to the file (it being read only); so this text is meant to clarify that `read_only` being `false` doesn't mean *you* can actually write to the file, just that "in general" someone is able to.
Configuration menu - View commit details
-
Copy full SHA for 56ba5af - Browse repository at this point
Copy the full SHA 56ba5afView commit details -
Rollup merge of rust-lang#120684 - carschandler:patch-1, r=nnethercote
Update E0716.md for clarity When reading through this, I got slightly hung up thinking the `let` it was referring to was the `let tmp` on line 25, which was confusing considering the comment states that the temporary is freed at the end of the block. I think adding this clarification could potentially help some beginners like myself without being overly verbose.
Configuration menu - View commit details
-
Copy full SHA for 4e8af6c - Browse repository at this point
Copy the full SHA 4e8af6cView commit details -
Rollup merge of rust-lang#121759 - RalfJung:addr_of, r=the8472
attempt to further clarify addr_of docs
Configuration menu - View commit details
-
Copy full SHA for e63d49f - Browse repository at this point
Copy the full SHA e63d49fView commit details -
Rollup merge of rust-lang#121815 - nnethercote:mv-gather_comments, r=…
…est31 Move `gather_comments`. To the module where it is used, so it doesn't have to be `pub`. r? ````@est31````
Configuration menu - View commit details
-
Copy full SHA for 5080da9 - Browse repository at this point
Copy the full SHA 5080da9View commit details -
Rollup merge of rust-lang#121835 - nnethercote:mv-HandleStore, r=bjorn3
Move `HandleStore` into `server.rs`. This just moves the server-relevant parts of handles into `server.rs`. It introduces a new higher-order macro `with_api_handle_types` to avoid some duplication. This fixes two `FIXME` comments, and makes things clearer, by not having server code in `client.rs`. r? ````@bjorn3````
Configuration menu - View commit details
-
Copy full SHA for b0de7d0 - Browse repository at this point
Copy the full SHA b0de7d0View commit details -
Rollup merge of rust-lang#121847 - shamatar:btreemap_fix_implicits, r…
…=cuviper Remove hidden use of Global Fixes rust-lang#121797
Configuration menu - View commit details
-
Copy full SHA for 9996a4a - Browse repository at this point
Copy the full SHA 9996a4aView commit details -
Rollup merge of rust-lang#121861 - tbu-:pr_floating_point_exact_examp…
…les, r=workingjubilee Use the guaranteed precision of a couple of float functions in docs
Configuration menu - View commit details
-
Copy full SHA for a57e0fc - Browse repository at this point
Copy the full SHA a57e0fcView commit details -
Rollup merge of rust-lang#121875 - estebank:e0277-drive-by, r=compile…
…r-errors Account for unmet T: !Copy in E0277 message ``` error[E0277]: the trait bound `T: !Copy` is not satisfied --> $DIR/simple.rs:10:16 | LL | not_copy::<T>(); | ^ the trait bound `T: !Copy` is not satisfied ``` instead of the current ``` error[E0277]: the trait bound `T: !Copy` is not satisfied --> $DIR/simple.rs:10:16 | LL | not_copy::<T>(); | ^ the trait `!Copy` is not implemented for `T` ```
Configuration menu - View commit details
-
Copy full SHA for 5321efb - Browse repository at this point
Copy the full SHA 5321efbView commit details -
Rollup merge of rust-lang#121888 - cppcoffee:style, r=Nilstrieb
style library/core/src/error.rs Add an extra blank line for clarity in distinguishing implementations.
Configuration menu - View commit details
-
Copy full SHA for 1415c24 - Browse repository at this point
Copy the full SHA 1415c24View commit details -
Rollup merge of rust-lang#121892 - Zalathar:expr-kind-let, r=Nadrieril
The ordinary lowering of `thir::ExprKind::Let` is unreachable After desugaring, `let` expressions should only appear inside `if` expressions or `match` guards, possibly nested within a let-chain. In both cases they are specifically handled by the lowerings of those expressions, so this case is currently unreachable. --- Context: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Lowering.20of.20.60thir.3A.3AExprKind.3A.3ALet.60.20is.20unreachable My conclusions are partly based on the observation that stubbing out this match arm doesn't cause any test failures. So either this really is unreachable, or it can be reached in some obscure circumstances that our test suite doesn't cover. If we end up needing this code (or something like it) for an implementation of rust-lang/rfcs#3573, it should be easy enough to pull it back out of version control history. I looked into having the `if`/`match` lowerings call back into `expr_into_dest`, but from what I can tell that won't work well, because there are extra scoping considerations that require some awareness of the enclosing if/match. r? `@Nadrieril`
Configuration menu - View commit details
-
Copy full SHA for 3de2576 - Browse repository at this point
Copy the full SHA 3de2576View commit details