Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make [from_str_radix_10] skip constant context #12787

Merged
merged 1 commit into from May 12, 2024

Conversation

J-ZhengLi
Copy link
Member

fixes: #12731


changelog: make [from_str_radix_10] skip constant context

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 11, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented May 12, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented May 12, 2024

📌 Commit 904c99c has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 12, 2024

⌛ Testing commit 904c99c with merge 9b446c7...

@bors
Copy link
Collaborator

bors commented May 12, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 9b446c7 to master...

@bors bors merged commit 9b446c7 into rust-lang:master May 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_str_radix_10 lint shows up in const contexts when the suggestion is not const
4 participants