Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add applicability filter to lint list page #12655

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add applicability filter to lint list page #12655

wants to merge 3 commits into from

Conversation

SpencerAWill
Copy link

changelog: Add applicability filter to lint list website.
Fixes #7958

Desktop view:
image

Mobile view:
image

@rustbot
Copy link
Collaborator

rustbot commented Apr 9, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 9, 2024
@SpencerAWill SpencerAWill changed the title Add applicability filter Add applicability filter to lint list page Apr 9, 2024
xFrednet
xFrednet reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny NIT, the rest looks good to me. Thank you for the addition :D

util/gh-pages/script.js Outdated Show resolved Hide resolved
@SpencerAWill @xFrednet
Remove debug helper.
c8a7e6e 
Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com>
@xFrednet
Copy link
Member

The changes look good to me, thank you! :D

@bors r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve filtering options for Clippy's lint list
3 participants
@SpencerAWill @rustbot @xFrednet