Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rustc_on_unimplemented in duplicated_attributes #12620

Merged
merged 1 commit into from May 12, 2024

Conversation

Nilstrieb
Copy link
Member

#[rustc_on_unimplemented(
    on(
        _Self = "&str",
        label = "`a"
    ),
    on(
        _Self = "alloc::string::String",
        label = "a"
    ),
)]

The lint treats this as a repetition because rustc_on_unimplemented::on::label appears twice, but that's ok.

Fixes #12619

changelog: [duplicated_attributes]: fix handling of rustc_on_unimplemented

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 2, 2024
@Nilstrieb
Copy link
Member Author

Oops, that's what I get for throwing something up quickly before going to bed. Will fix (or someone else can fix it for me if you want to :D).

@Nilstrieb Nilstrieb force-pushed the dupattr branch 2 times, most recently from f035522 to 558f468 Compare April 4, 2024 18:21
@bors
Copy link
Collaborator

bors commented Apr 9, 2024

☔ The latest upstream changes (presumably #12646) made this pull request unmergeable. Please resolve the merge conflicts.

@Nilstrieb Nilstrieb force-pushed the dupattr branch 2 times, most recently from 838063e to 1f9e392 Compare May 1, 2024 15:53
@Nilstrieb
Copy link
Member Author

r? xFrednet

@rustbot rustbot assigned xFrednet and unassigned Jarcho May 9, 2024
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meow Meow, looks good to me! =^.^=

@xFrednet
Copy link
Member

xFrednet commented May 12, 2024

In code's domain where errors hide,
Two cats, sleek and full of pride,
They prowled through lint, keen and bright,
Their gaze fixed on bugs in the night.

"Duplicated attributes," they mew,
A bug they sought to construe,
Unstable feature, a lurking snare,
In rustc_on_unimplemented's lair.

With paws deft, they traced the line,
Unraveling errors, oh so fine,
Their purrs like whispers, soft and sweet,
Guiding devs to a bug's defeat.

So here's to cats, both wise and keen,
Who conquer bugs in code's machine,
Their legacy, a lint refined,
In their honor, let us r+.

@bors
Copy link
Collaborator

bors commented May 12, 2024

📌 Commit b10be16 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 12, 2024

⌛ Testing commit b10be16 with merge 412b691...

@Nilstrieb
Copy link
Member Author

meow :3

@bors
Copy link
Collaborator

bors commented May 12, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 412b691 to master...

@bors bors merged commit 412b691 into rust-lang:master May 12, 2024
5 checks passed
@Nilstrieb Nilstrieb deleted the dupattr branch May 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of rustc_on_unimplemented for duplicated_attributes
5 participants