Partial float refactor #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to see this merged, but the PRs newer than this one that are currently open should be merged first |
|
Can you rebase? |
The old tests were hacky and did not cover nearly as many cases as the new tests do.
rust-lang/rust#51647 is fixed but panic-handler is still needed
AaronKutch
force-pushed
the
float_refactor
branch
2 times, most recently
from
780b8de
to
11d4b2f
Compare
|
I got everything to work except for adding clippy to the CI. Issue rust-lang/rustup#1501 doesn't look like it was resolved. |
|
Can you try applying the workaround suggest by @RalfJung for clippy? |
AaronKutch
force-pushed
the
float_refactor
branch
3 times, most recently
from
dd376b1
to
db8da99
Compare
AaronKutch
force-pushed
the
float_refactor
branch
from
db8da99
to
d662521
Compare
|
Sorry if I spammed anyone's inbox, GHA always gives me trouble with environment variables. Anyway, I think |
This was referenced Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the more troublesome parts of the floating point folder, adds more tests, removes the old test system, and fixes all clippy warnings. Fixes issues #395, #197, #162, #168. Issues #75 and #154 should also be closed.