Partial revert of the float conversion refactor in #192 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts "Convert int_to_float! to a function".
This partially reverts commit "Convert float_to_int! into a function"
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to make updating compiler-builtins for newer rustc possible again (cc #197). I don't really know what #197 is about yet, so I want to un-block updates of compiler-builtins by reverting the conversion implementation to its older macro form. The other changes of #192 are left, even the changes to
mod.rsdone by the two partially reverted commits.I've tested the changes of this PR with a local build of rustc and it can't reproduce #197. However, it does not close the issue, as optimally we'd have the code back in master again.
r? @alexcrichton