Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --out-dir to --artifact-dir #13809

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Rename --out-dir to --artifact-dir #13809

merged 2 commits into from
Jun 7, 2024

Commits on Jun 7, 2024

  1. Rename out-dir to artifact-dir 

    Per discussion in rust-lang#6790. The
--out-dir CLI option and out-dir config option are often confused with
the OUT_DIR environment variable, when the two serve very different
purposes (the former tells Cargo where to copy build artifacts to,
whereas the OUT_DIR environment variable is set *by* Cargo to tell
build scripts where to place their generated intermediate artifacts).
Renaming the option to something less confusing is a prerequisite to
stabilizing it.
    @valadaptive
    valadaptive committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4b309bc View commit details
    Browse the repository at this point in the history

  2. Add tests for out-dir option deprecation 

    Ensure that the old options still work and provide the proper
deprecation warning.
    @valadaptive
    valadaptive committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    0aac303 View commit details
    Browse the repository at this point in the history