Enable Running Test Cases on Windows #280
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ping - needed for Windows support
nagisa
reviewed
Oct 8, 2021
| #[cfg(not(target_family = "windows"))] | ||
| let expected_err = "File exists (os error 17)"; | ||
| #[cfg(target_family = "windows")] | ||
| let expected_err = "The file exists. (os error 80)"; |
There was a problem hiding this comment.
Won't this fail to work on Windows systems that have the system language set to some other language than English?
There was a problem hiding this comment.
Good question, I will look in to the localization impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#279 includes changes necessary to start supporting Windows once support also lands in
rustc(see rust-lang/rust#89369). I wanted to explore the current state of support by running thecargo-fuzztest suite with therusttoolchain built with Windows support forasansymbols enabled. I've run in to two issues so far.First Issue - Addressed
The test suite generates a set of fuzz targets and associated
Cargo.tomlmanifest files. Those files include path configuration that, up until this point, has leveraged thePathBufdisplay functionality to render the paths as strings for the generatedtomlfile. This breaks on Windows.tomlneeds\in Windows paths to be escaped, which display does not do. Using thetomlserializer address this in a cross platform way. I have tested this change on Windows and Linux. While I don't have a Mac system to test on I have no reason to think this is a risky change there.Second Issue - Work In Progress
With a dev toolchain built and linked including the changes from rust-lang/rust#89369 and the above path issue addressed there are still failures of the test cases on Windows. All test cases that execute fuzz tests fail with:
References to this error I've found suggest it has to do with calling
cargofrom within another execution ofcargoon Windows, which is the behavior we're attempting in these test cases. Reference rust-lang/rust-clippy#3118. Clippy addressed this with hardcoding the+nightlytoolchain in their calls tocargowhich might work here when/if rust-lang/rust#89369 or other support hits nightly. I'm investigating other options.