Allow unexpected_cfgs #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
05-08-allow-unexpected-cfgs
branch
from
c5c5213
to
bf3564a
Compare
Currently we use `cfg_attr` to disable the formatter so that the attribute can be on an expression. There was a new lint introduced into nightly just recently that checks cfg args, this `cfg_attr` usage triggers it. Use `rustfmt::skip` instead and put it on the function because it doesn't currently work on expressions.
Rust `nightly` just introduced a new lint that breaks us, disable it. Same as rust-bitcoin/rust-bitcoin#2748 Please see 2748 for full description of the issue this resolves.
tcharding
force-pushed
the
05-08-allow-unexpected-cfgs
branch
from
bf3564a
to
ed869d7
Compare
apoelstra
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust
nightlyjust introduced a new lint that breaks us, disable it.Same as rust-bitcoin/rust-bitcoin#2748
Please see 2748 for full description of the issue this resolves.
Note, the first patch uses
rustfmt::skipinstead ofcfg_attrto save triggering the lint in example code.