fix: makes Header.to_hashmap() not call unwrap. #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently encountered an issue where the to_hashmap method will cause a panic (issue). #276 reports a similar problem. I've refactored the function to return a
Result
allowing the caller to handle the failure. I understand this changes the API and it may be considered unconventional to have ato_*
method return a result, so I'm open to discussion about other ways to aviod the panic.