docs: don't use wildcard version, replace 'extern crate' with 'use' #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcroote
reviewed
Jun 16, 2023
| //! | ||
| //! ```rust | ||
| //! extern crate bio; |
There was a problem hiding this comment.
Good find- though it looks like the repo has a number of instances of this pattern. Would you feel comfortable replacing or deleting, as appropriate, those as well?
There was a problem hiding this comment.
Sure, sounds good! Those are remainders from the early days of Rust. Rust-bio development started in 2015.
johanneskoester
approved these changes
Sep 12, 2023
jch-13
pushed a commit
to jch-13/rust-bio
that referenced
this pull request
Dec 20, 2023
…ust-bio#531) * docs: don't use wildcard version, replace 'extern crate' with 'use' * docs: don't imply that crate items cannot be used before 'use bio'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wildcard version specifications are considered bad practice.
usecan be used to import crate items since Rust edition 2018.