Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 1.0.0 #498

Closed
wants to merge 1 commit into from
Closed

chore: release 1.0.0 #498

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

🤖 I have created a release *beep* *boop*

1.0.0 (2022-08-19)

⚠ BREAKING CHANGES

Features

  • Update strum and ordered-float dependencies and change From into TryFrom for NotNan. (#491) (57ccf8f)

This PR was generated with Release Please. See documentation.

@adam-azarchs
Copy link
Contributor

I don't think this is supposed to be 1.0.0.

@dcroote
Copy link
Contributor

dcroote commented Aug 20, 2022

I don't think so either. The cause appears to be #491 using "!feat" which is treated as a SemVer major.

@adam-azarchs
Copy link
Contributor

As I understand it, to fix this someone would have to push an empty commit like

git commit --allow-empty -m "chore: release 0.42.0" -m "Release-As: 0.42.0"

@github-actions github-actions bot closed this Aug 30, 2022
@adam-azarchs
Copy link
Contributor

I put an appropriate line in #499 so now this is replaced by #500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants