Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Update strum and ordered-float dependencies and change From<LogProb> into TryFrom<LogProb> for NotNan<f64>. #491

Merged
merged 11 commits into from Aug 19, 2022
Merged

feat!: Update strum and ordered-float dependencies and change From<LogProb> into TryFrom<LogProb> for NotNan<f64>. #491

merged 11 commits into from Aug 19, 2022

Commits on May 4, 2022

  1. Update strum crates 

    Figure we'll need to change eventually.
    @evolvedmicrobe
    evolvedmicrobe committed May 4, 2022
    Copy the full SHA
    2f1b29e View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Upgrade Ordered Float 

    ordered-float ditched their From<f64> methods for NotNan and instead made them TryFrom<f64> (reem/rust-ordered-float@39f76bb).  This change makes sense because From trait implementations generally shouldn’t panic, which the implementation did if the f64 was a NaN, and so TryFrom is more appropriate.  This commit accounts for this change in the upgrade
    @evolvedmicrobe
    evolvedmicrobe committed May 31, 2022
    Copy the full SHA
    dd2db90 View commit details
    Browse the repository at this point in the history

  2. Remove Deprecated Function Call 

    `ndarray` has renamed `genrows()` to `rows()`
    @evolvedmicrobe
    evolvedmicrobe committed May 31, 2022
    Copy the full SHA
    a42e59d View commit details
    Browse the repository at this point in the history

  3. Formatting Fix

    @evolvedmicrobe
    evolvedmicrobe committed May 31, 2022
    Copy the full SHA
    c30ce2f View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG

    @evolvedmicrobe
    evolvedmicrobe committed May 31, 2022
    Copy the full SHA
    080b9f7 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. From -> TryFrom` 

    The conversion from LogProb is not guaranteed to succeed, so we use `TryFrom` instead of `From`, as per the Rust docs:

```Note: The From trait must not fail. The From trait is intended for perfect conversions. If the conversion can fail or is not perfect, use TryFrom.```

Note this does change the API.
    @evolvedmicrobe
    evolvedmicrobe committed Jun 1, 2022
    Copy the full SHA
    096e156 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Adam Azarchs <adam.azarchs@10xgenomics.com>
    @evolvedmicrobe @adam-azarchs
    evolvedmicrobe and adam-azarchs committed Aug 11, 2022
    Copy the full SHA
    aaffd64 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Update CHANGELOG.md

    @johanneskoester
    johanneskoester committed Aug 17, 2022
    Copy the full SHA
    0ad0658 View commit details
    Browse the repository at this point in the history

  2. Update Cargo.toml

    @johanneskoester
    johanneskoester committed Aug 17, 2022
    Copy the full SHA
    c52604d View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Fix build issue.

    @adam-azarchs
    adam-azarchs committed Aug 19, 2022
    Copy the full SHA
    aa90c4e View commit details
    Browse the repository at this point in the history

  2. Merge 'master' into nd/update_strum

    @adam-azarchs
    adam-azarchs committed Aug 19, 2022
    Copy the full SHA
    99f2ba8 View commit details
    Browse the repository at this point in the history